Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust couchapp push command to match CMSCouchapp #10485

Merged
merged 2 commits into from
May 12, 2021

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented May 11, 2021

Part of the needed work for fixing #10303 and #10076

Status

ready

Description

As we migrate to a home-maintained python couchapp library:
https://pypi.org/project/CMSCouchapp/

there has been a few changes to some API signatures.

This PR provides the necessary changes to be able to deploy CouchDB applications with the new CMSCouchapp dependency, which is still to be inserted into our cmsdist spec files.

Is it backward compatible (if not, which system it affects?)

no

Related PRs

none

External dependencies / deployment changes

cmsdist spec changes: cms-sw/cmsdist#6892
With this, a new WMAgent docker image can be created.

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: failed
    • 275 new failures
    • 2 tests no longer failing
    • 12 changes in unstable tests
  • Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 70 comments to review
  • Pylint py3k check: failed
    • 0 errors and warnings that should be fixed
    • 14 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
    • 36 comments to review
  • Python3 compatibility checks: succeeded
    • there are suggested fixes for newer python3 idioms

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11743/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: failed
    • 1 new failures
  • Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 70 comments to review
  • Pylint py3k check: failed
    • 0 errors and warnings that should be fixed
    • 14 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
    • 36 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11744/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

Cool! First test was based on the old docker image (1.4.7) and previous couchapp.
The second unit tests (the one above) is using a freshly built docker image based on 1.4.9.pre1, with CMSCouchapp instead.

@amaltaro
Copy link
Contributor Author

Test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: failed
    • 5 new failures
    • 271 tests no longer failing
    • 12 changes in unstable tests
  • Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 70 comments to review
  • Pylint py3k check: failed
    • 0 errors and warnings that should be fixed
    • 14 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
    • 36 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11745/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

Merging it now otherwise the baseline tests will keep failing. I will follow up on the unit tests in a different PR. FYI @todor-ivanov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants